commit 26e202d82e698b86a2f46473b92a2d173ffc330a Author: OverPoweredDev Date: Thu Jun 10 19:42:24 2021 +0530 fixed language select bug diff --git a/background/storage.js b/background/storage.js index e197c3d..7f2df36 100644 --- a/background/storage.js +++ b/background/storage.js @@ -28,6 +28,7 @@ function getLangPairs() { function getLanguageCodeMap(){ return { + "detect" : "Detect Language", "deu" : "Deutsch", "nld" : "Dutch", "heb" : "Hebrew", diff --git a/popup/options.js b/popup/options.js index 2fc5382..96e3d8f 100644 --- a/popup/options.js +++ b/popup/options.js @@ -58,7 +58,7 @@ function createDropdown(parent) { function getSelectedLanguage(selector) { selector.addClass("selected-language"); - let text = $(".selected-language").text(); + let text = $(".selected-language").val(); selector.removeClass("selected-language"); return text; diff --git a/popup/popup.js b/popup/popup.js index 353b8cd..98700bf 100644 --- a/popup/popup.js +++ b/popup/popup.js @@ -126,6 +126,10 @@ async function getTranslation(inputText, sourceLanguage, targetLanguage) { return outputText; } +async function detectInputLanguage() { + // TODO +} + function getTargetLanguage(){ let languageCode = $("#target-language").val(); @@ -137,12 +141,14 @@ function getTargetLanguage(){ } } -function getSourceLanguage(){ +async function getSourceLanguage(){ let languageCode = $("#source-language").val(); - if(languageCode === 'select' || languageCode === undefined){ + if (languageCode === undefined) { $("#source-language").addClass('error'); return null; + } else if (languageCode === 'detect') { + await detectInputLanguage(); } else { return languageCode } @@ -203,7 +209,7 @@ function createSourceDropdown(parent, target = "") { list = getSourceList(); } - parent.append(""); + parent.append(""); list.forEach((languageCode) => { let languageName;